Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSharpier formatter #165

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Add CSharpier formatter #165

merged 2 commits into from
Oct 28, 2023

Conversation

JesperLundberg
Copy link
Contributor

No description provided.

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; could you fix the luacheck error?

@stevearc
Copy link
Owner

Also just a note, the documentation changes aren't necessary. You don't have to change anything, but they'll all be overwritten by the doc autogen bot after merge. For new formatters you only have to add the formatter file.

@JesperLundberg
Copy link
Contributor Author

Fixed the warning.

Also, I stole with pride from another PR here and just copied what they had done. 😅

Now I know til next time that I only need to add formatter file though. :)

@stevearc
Copy link
Owner

No worries, I think that's how most people do it and there's no problem with it (apart from a bit more work for you). Thanks for the PR!

@stevearc stevearc merged commit b2368ff into stevearc:master Oct 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants