Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jsonnetfmt #230

Merged
merged 4 commits into from
Dec 5, 2023
Merged

feat: add jsonnetfmt #230

merged 4 commits into from
Dec 5, 2023

Conversation

dadav
Copy link
Contributor

@dadav dadav commented Dec 2, 2023

Add support for jsonnetfmt. It's also available in Mason, so native conform.nvim support would be cool.

@dadav dadav marked this pull request as ready for review December 4, 2023 10:39
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about the link

---@type conform.FileFormatterConfig
return {
meta = {
url = "https://github.com/google/go-jsonnet/cmd/jsonnetfmt",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL appears to be broken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed it.

@dadav dadav requested a review from stevearc December 4, 2023 19:20
@stevearc stevearc merged commit 769dde8 into stevearc:master Dec 5, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants