Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: formatter config functions take self as first argument #233

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

stevearc
Copy link
Owner

@stevearc stevearc commented Dec 5, 2023

cc @mehalter related to #221

With this change, we can start adding options tables to formatters, which will open up more customization opportunities for formatters that need it (e.g. prettier)

@stevearc stevearc force-pushed the stevearc-self-arg branch 2 times, most recently from aa7d9ae to 91af27c Compare December 5, 2023 18:51
@mehalter
Copy link
Contributor

mehalter commented Dec 5, 2023

This looks very cool! I should have some time later today or tomorrow morning to take a deeper look at this.

I could also look to test this with the prettier case that I have. If you want, this could end up being an additional example to put in the documentation to provide support to users as to why something like this is necessary and how to use it :)

@stevearc
Copy link
Owner Author

stevearc commented Dec 5, 2023

Feel free to build out some functionality for prettier if you like, but there's no rush. I'll merge this in the next day or so and plan to follow up with generating documentation.

@stevearc stevearc merged commit 659838f into master Dec 7, 2023
7 checks passed
@stevearc stevearc deleted the stevearc-self-arg branch December 7, 2023 06:20
@wookayin
Copy link
Contributor

wookayin commented Dec 7, 2023

Thanks for the compatibility layer, not completely breaking existing configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants