Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add buf as protobuf linter #43

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat: add buf as protobuf linter #43

merged 1 commit into from
Sep 14, 2023

Conversation

buztard
Copy link
Contributor

@buztard buztard commented Sep 14, 2023

No description provided.

stevearc
stevearc requested changes Sep 14, 2023
View reviewed changes
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does buf support stdin? Just looking at the cli docs it doesn't mention it anywhere. We may need to use the -w flag and set stdin = false in the definition.

@buztard
Copy link
Contributor Author

buztard commented Sep 14, 2023

Oh, you're right, it ignores stdin and scans the whole package instead. My bad

@stevearc
Copy link
Owner

Thanks for the PR!

@stevearc stevearc merged commit 2b73887 into stevearc:master Sep 14, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevearc stevearc stevearc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buztard @stevearc