Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add markdownlint, stylelint, codespell, and biome #45

Merged
merged 5 commits into from
Sep 14, 2023
Merged

feat: add markdownlint, stylelint, codespell, and biome #45

merged 5 commits into from
Sep 14, 2023

Conversation

chrisgrieser
Copy link
Contributor

No description provided.

@chrisgrieser chrisgrieser changed the title feat: add markdownlint, stylelint & codespell feat: add markdownlint, stylelint, codespell, and biome Sep 14, 2023
@stevearc
Copy link
Owner

Thanks! For the merge conflicts: you don't actually need to update the README. I have a github action that will make sure it's up-to-date.

@chrisgrieser
Copy link
Contributor Author

chrisgrieser commented Sep 14, 2023

ah, I see. should I just reset the file?

edit: oh, I see, the bot was already active. Yeah, I just resolved the merge conflict.

@chrisgrieser
Copy link
Contributor Author

check failed due to wrong indentation in a file. Pushed a fix

@stevearc
Copy link
Owner

Looks like another merge conflict >.<

You can just ignore the README changes entirely and only commit the new files. The bot will follow up with a commit like ee679d1 and add the proper entries.

@chrisgrieser
Copy link
Contributor Author

yeah, the merge conflict came from the fact that you merged a PR with new linters in the meantime :(

anyway, I just resolved the conflict, which should do it

@stevearc
Copy link
Owner

Thanks for the PR!

@stevearc stevearc merged commit 580ab18 into stevearc:master Sep 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants