Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding Social Badge, the edge of the background should cover the bottom of the label. #208

Open
BuczynskiRafal opened this issue May 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@BuczynskiRafal
Copy link

When adding a social badge, the background edge should cover the bottom of the label. Currently the background edge is tied to the code snippet. It can be extended to include the social badge but this results in a large margin at the top.

image
@stevebauman
Copy link
Owner

Hey @BuczynskiRafal,

This was of a stylistic choice on my part. Maybe I can make this an option, as I kind of like how the badge doesn't bump the code window out of its center position.

@BuczynskiRafal
Copy link
Author

I thought this was not intended, but you are right, not everyone can expect this. I step around this by setting the bottom margin to 50. Perhaps the option to shift the margin can be added in “SOCIAL BADGE PROPERTIES” as a checkbox?

@stevebauman stevebauman added the enhancement New feature or request label May 26, 2024
@stevebauman
Copy link
Owner

I like that idea! 👍 I'll add this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants