-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message for improper URLs are attributed to incorrect line #609
Comments
It looks like we've already tried to deal with this by scanning through the code (regex-style) to look for Empty URL Types ( Line 1711 in 42a2c23
I should be able to clean up the first two cases a bit fairly easily, so should be able to get that done soon. |
(Also setBackdropURL has an error message if a string isn't provided as the first argument, which should be added to setImageURL as well) |
Further investigation of this makes me not trust how we handle errors in Woof. I believe when we try to GET an image that doesn't exist, we throw two errors. The 404 error seems to not be caught properly, and is making it hard for me to properly track down how the errors are propagating. |
In this example:
https://woofjs.com/create.html#hallpell_url-error
the error occurs in line 9 (where no URL is provided to setImageURL), but Woof reports the error on line 1. Need to process this error differently in some way.
The text was updated successfully, but these errors were encountered: