feat(stream): emmit an empty string to down stream if commit cannot b…

…e parsed

This makes it possible for down stream to know if one commit cannot be parsed.`

BREAKING CHANGE: It no longer skips the chunk if commit cannot be parsed. An empty string is passed to down stream

README.md

@@ -100,7 +100,7 @@ stream
 
 ### conventionalCommitsParser([options])
 
-Returns an object stream.
+Returns an object stream. If there is any malformed commits it will be gracefully ignored (an empty data will be emitted so down stream can notice).
 
 #### options
 

cli.js

@@ -73,7 +73,11 @@ if (length > 0) {
   stream.pipe(conventionalCommitsParser(cli.flags))
     .pipe(JSONStream.stringify('', '', ''))
     .pipe(through(function(chunk, enc, cb) {
-      cb(null, 'result: ' + chunk + '\n\n');
+      if (chunk.toString() === '""') {
+        cb(null, 'Commit cannot be parsed\n\n');
+      } else {
+        cb(null, 'Result: ' + chunk + '\n\n');
+      }
     }))
     .pipe(process.stdout);
 

index.js

@@ -37,7 +37,7 @@ function conventionalCommitsParser(options) {
     if (commit) {
       cb(null, commit);
     } else {
-      cb();
+      cb(null, '');
     }
   });
 }

test/index.spec.js

@@ -73,11 +73,12 @@ describe('conventionalCommitsParser', function() {
     stream
       .pipe(conventionalCommitsParser())
       .pipe(through.obj(function(chunk, enc, cb) {
-        expect(chunk.hash).to.equal('13f31602f396bc269076ab4d389cfd8ca94b20ba');
-        i++;
+        if (++i !== 2) {
+          expect(chunk.hash).to.equal('13f31602f396bc269076ab4d389cfd8ca94b20ba');
+        }
         cb();
       }, function() {
-        expect(i).to.equal(2);
+        expect(i).to.equal(3);
         done();
       }));
   });