Remove equality constriant number check when adding constraint #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have noticed that when the number of equality constraints exceeds the number of variables, NLOPT refuses to add them. However, this does not necessarily mean that there is no solution as there can be redundancy in the constraints that may be non-trivial to remove for the non-linear situation from the user side. Moreover, even if the number of equality constraints is less than the number of variables, this check cannot guarantee the solution's existence. So this check seems not to make a lot of sense.
Therefore, I removed the check in this PR, or do you prefer a CMake option and preprocess directive that can conditionally disable it?