Only call .toString() on sass files #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy2be
force-pushed
the
only-toString-sass-files
branch
from
a40034a
to
260fda1
Compare
Calling .toString() is a fairly expensive operation, which allocates a new string, and copies all of the contents of the file Buffer into that string. This is fairly fast for small files or small sites, but quickly starts to take seconds of the total build time on medium sized sites (in my case, roughly 2 seconds of the overall build was this call to toString()!) This change makes it so we only call toString() if we actually want the result - i.e. if it as a sass file. Thus, we don't call it on markdown files, image files, video files, etc.
crazy2be
force-pushed
the
only-toString-sass-files
branch
from
260fda1
to
d443be9
Compare
crazy2be
commented
Jan 2, 2019
| ].join('')); | ||
| } else if (err) { | ||
| error = new Error(err); | ||
| } |
There was a problem hiding this comment.
Just indentation changes due to the inversion of the if statement.
|
Hey @crazy2be! This is great, thanks for taking the time to put together a PR! I'll try and get this merged and released soon. I'll say sorry in advance for any delays on my part to get this deployed, my free time is really limited at the moment 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling .toString() is a fairly expensive operation, which allocates
a new string, and copies all of the contents of the file Buffer into
that string. This is fairly fast for small files or small sites, but
quickly starts to take seconds of the total build time on medium
sized sites (in my case, roughly 2 seconds of the overall build was
this call to toString()!)
This change makes it so we only call toString() if we actually want
the result - i.e. if it as a sass file. Thus, we don't call it on
markdown files, image files, video files, etc.