Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle object/array values a bit smoother #24

Open
jonmorehouse opened this issue May 9, 2014 · 3 comments
Open

Handle object/array values a bit smoother #24

jonmorehouse opened this issue May 9, 2014 · 3 comments

Comments

@jonmorehouse
Copy link
Contributor

I'm currently building out the ability to pass an object,array to the the api as the key value. This will be stringified behind the scenes. Upon return, this value will be serialized back to json. Is this something that makes sense for this module?

@jonmorehouse
Copy link
Contributor Author

Here's my current branch. Let me know if you have any thoughts on this functionality. I'll make a pull-request when I have some time to build out some tests. https://github.com/jonmorehouse/node-etcd/tree/json

@stianeikeland
Copy link
Owner

I think this sounds useful, avoids having to manually (de)serialize all the time. The only question is, can it potentially break something? (i think it should be fine)

@jonmorehouse
Copy link
Contributor Author

Cool, I'm using my fork on a few projects ... and haven't ran into any issues from my application. I'm hoping to find a little time this week to write out some more tests to cover this functionality. I'll make a pull request when I get something I think others could use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants