Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout + watcher doesn't make sense #63

Open
trystanj opened this issue Sep 30, 2016 · 0 comments
Open

Timeout + watcher doesn't make sense #63

trystanj opened this issue Sep 30, 2016 · 0 comments

Comments

@trystanj
Copy link
Contributor

When setting a timeout through the constructor, the timeout is applied through the watcher as well (since it's sugar over the GET request).

This doesn't make sense. If the etcd directory had no activity within the timeout window, the request module closes the connection (and kicks off the exponential backoff, which means watches could be ridiculously delayed).

If this is intentional, it's easy enough for me to use a workaround and build my own timeout method and avoid the constructor option. If not, I'd be happy to work on a refactoring in a PR that separates out this configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant