Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Change to URL-Parse Dependency #75

Open
DerekTBrown opened this issue Aug 3, 2017 · 1 comment
Open

Breaking Change to URL-Parse Dependency #75

DerekTBrown opened this issue Aug 3, 2017 · 1 comment

Comments

@DerekTBrown
Copy link
Contributor

In creating a PR which updates the url-parse dependency, I realized there is a breaking change in an upcoming version. Once the following issue is resolved, the dependency can be updated:

unshiftio/url-parse#69
@DerekTBrown
Copy link
Contributor Author

@stianeikeland supposedly this is the expected behavior. This gives us two options:

  1. Update the readme and tests to require the protocol in the string
  2. Add a short snippet which appends "http://" on strings without the protocol set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DerekTBrown