Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message with invalid URL #79

Open
ghost opened this issue Sep 18, 2017 · 1 comment
Open

No error message with invalid URL #79

ghost opened this issue Sep 18, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 18, 2017

If I initialize the client with a bogus url - http:localhost:4001 instead of http://localhost:4001 - the library gives me absolutely NO indication that there is anything wrong. No connection failure. No url parse failure. No host lookup failure. No error message in callbacks. All of my get and set methods simply never have their callback called at all. This is a totally blocking error that deserves to have some pretty significant logging and error notification happening. To just silently swallow the error and leave no clue as to what went wrong is about the least reasonable response - and one that likely wastes huge quantities of developer time cumulatively across all users of this library. I highly doubt I'm the first person to fat-finger a URL.

Additionally, the docs say that the Etcd() constructor will 'callback with an error' if it exhausts all URLs when attempting to connect - but according to the docs, the Etcd() constructor doesn't take a callback.

@roccomuso
Copy link

I Agree.
It doesn't have a callback, neither emits an error event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant