You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is not unref'ed or returned, so there is no way to cleanly end a process that is waiting on this timer. I would prefer that it was just unref'ed, but at worst it needs to be returned so the caller can unref it. Or an option of some sort... I can make a PR to unref it if that's the desired approach
The text was updated successfully, but these errors were encountered:
(Never mind, returning it won't help because it's an internal method. So it would need to be an instance var and cleaned up as part of watcher destruction)
The timer created here:
node-etcd/src/watcher.coffee
Line 93 in 1bb5f4d
Is not unref'ed or returned, so there is no way to cleanly end a process that is waiting on this timer. I would prefer that it was just unref'ed, but at worst it needs to be returned so the caller can unref it. Or an option of some sort... I can make a PR to unref it if that's the desired approach
The text was updated successfully, but these errors were encountered: