Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unref timers #87

Open
djMax opened this issue Aug 20, 2019 · 1 comment
Open

unref timers #87

djMax opened this issue Aug 20, 2019 · 1 comment

Comments

@djMax
Copy link

djMax commented Aug 20, 2019

The timer created here:

setTimeout @_watch, timeout

Is not unref'ed or returned, so there is no way to cleanly end a process that is waiting on this timer. I would prefer that it was just unref'ed, but at worst it needs to be returned so the caller can unref it. Or an option of some sort... I can make a PR to unref it if that's the desired approach

@djMax
Copy link
Author

djMax commented Aug 20, 2019

(Never mind, returning it won't help because it's an internal method. So it would need to be an instance var and cleaned up as part of watcher destruction)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant