Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

dbt Hamilton Example #240

Closed
datarshreya opened this issue Dec 3, 2022 · 4 comments
Closed

dbt Hamilton Example #240

datarshreya opened this issue Dec 3, 2022 · 4 comments
Assignees
Labels
triage label for issues that need to be triaged.

Comments

@datarshreya
Copy link
Contributor

datarshreya commented Dec 3, 2022

Notes on the dbt Hamilton example found at hamilton/examples/dbt:

I ran this with

dbt-core==1.3.1
dbt-duckdb==1.3.2
dbt-python==0.1
scikit-learn==1.1.3
sf-hamilton==1.11.0
pandera==0.13.4
  1. requirements.txt states dbt as a requirement. As of v1.0.0, pip install dbt is no longer supported. dbt-core would have to be specified instead. Is there a specific version of dbt this should/can be run with? It could be helpful to specify versions in the requirements file.

  2. There is an extra space while specifying the -r option in the pip install command. Should be pip install -r requirements.txt instead of pip install - r requirements.txt

  3. dbt run is throwing an error due to a missing pandera requirement, which can be added to the requirements file. The run was successful after pip install pandera. Before the dbt-fal commit, sqlalchemy was also a missing requirement and had to be added.

Happy to do a PR to make these changes! This is also my first open source Github issue, any feedback is welcome!

@elijahbenizzy
Copy link
Collaborator

Great first issue! Thank you for your feedback -- appreciate you taking it for a spin.

All seem reasonable and we welcome a PR. TBH I'm not sure the requirements problem/why it's happening -- hit something similar then got distracted, debugging this was tricky. Will loop in the FAL folks to get to the bottom of this. For now your fix will suffice quite well. Looking forward to your PR.

@skrawcz skrawcz self-assigned this Dec 3, 2022
@skrawcz skrawcz added the triage label for issues that need to be triaged. label Dec 3, 2022
@skrawcz
Copy link
Collaborator

skrawcz commented Dec 3, 2022

@datarshreya happy for the PR if you want to, else I'll triage and confirm your fix :)

@datarshreya
Copy link
Contributor Author

Will work on the PR!

@skrawcz
Copy link
Collaborator

skrawcz commented Dec 4, 2022

Verified this fix. Thanks @datarshreya.

@skrawcz skrawcz closed this as completed Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage label for issues that need to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants