Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stlab/concurrency/future.hpp won't compile with C++20 #305

Closed
tetsuhaut opened this issue May 28, 2020 · 2 comments
Closed

stlab/concurrency/future.hpp won't compile with C++20 #305

tetsuhaut opened this issue May 28, 2020 · 2 comments
Labels
fixed-in-main

Comments

@tetsuhaut
Copy link

tetsuhaut commented May 28, 2020 •
edited
Loading

Hello,
After updating my local Visual Studio, my program didn't compile anymore. It crashed on the usage of std::result_of and std::result_of_t in the file stlab/concurrency/future.hpp. Looking into it, I found out that this type is deprecated in C++17, and removed from C++20. I fixed the problem by replacing std::result_of_t<F(arg)> by std::invoke_result_t<F, arg>.
@FelixPetriconi
Copy link
Member

Thanks for notification. I will apply a fix for it soon.

@FelixPetriconi
Copy link
Member

Fixed in 1.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed-in-main
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FelixPetriconi @tetsuhaut