Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong extract command in FindLibUSB.cmake #510

Closed
slyshykO opened this issue Nov 5, 2016 · 2 comments · Fixed by #511
Closed

Wrong extract command in FindLibUSB.cmake #510

slyshykO opened this issue Nov 5, 2016 · 2 comments · Fixed by #511

Comments

@slyshykO
Copy link
Collaborator

slyshykO commented Nov 5, 2016

diff --git a/cmake/modules/FindLibUSB.cmake b/cmake/modules/FindLibUSB.cmake
index 45472b9..84020b9 100644
--- a/cmake/modules/FindLibUSB.cmake
+++ b/cmake/modules/FindLibUSB.cmake
@@ -24,7 +24,7 @@ if(WIN32 OR CMAKE_VS_PLATFORM_NAME OR MINGW OR MSYS)
                )
        endif()
        file(MAKE_DIRECTORY ${LIBUSB_WIN_OUTPUT_FOLDER})
-       execute_process(COMMAND ${ZIP_LOCATION} x -y ${LIBUSB_WIN_ARCHIVE_PATH} -o${LIBUSB_WIN_OUTPUT_FOLDER})
+       execute_process(COMMAND ${ZIP_EXECUTABLE} x -y ${LIBUSB_WIN_ARCHIVE_PATH} -o${LIBUSB_WIN_OUTPUT_FOLDER})
 endif()
@xor-gate
Copy link
Member

xor-gate commented Nov 7, 2016

That a good catch, could you create a pull request so you get all the credits? 👍

@xor-gate
Copy link
Member

xor-gate commented Nov 7, 2016

Thanks!

@xor-gate xor-gate closed this as completed Nov 7, 2016
@Nightwalker-87 Nightwalker-87 added this to the v1.3.0 milestone Mar 17, 2020
@Nightwalker-87 Nightwalker-87 linked a pull request Mar 17, 2020 that will close this issue
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants