Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the requirement about "pandoc" is configurable #479

Closed
gerryqd opened this issue Sep 21, 2016 · 5 comments
Closed

Make the requirement about "pandoc" is configurable #479

gerryqd opened this issue Sep 21, 2016 · 5 comments

Comments

@gerryqd
Copy link

gerryqd commented Sep 21, 2016

Hi,

I am using stlink for several months, I buit it on Cygwin, but after recent upgrades, I cannot able to build it out successfully. Seems that "pandoc" is required to generate the manpages.

Is it possilbe to make it configurable? For example, "cmake MANPAGES=NONE".

Or if it cannot find the "pandoc", it will not generate the manpges, just as it checks for the "GTK".

Thanks & Regards,
Gerry

@xor-gate
Copy link
Member

You are right, currently the Release target will not generate the man-pages with pandoc. The Debug target will. I will patch it so we have cmake option like: STLINK_ENABLE_DOC (like nanomsg does: https://github.com/nanomsg/nanomsg/blob/master/CMakeLists.txt#L90-L97)

@xor-gate xor-gate added this to the v1.3.0 milestone Sep 21, 2016
@xor-gate xor-gate self-assigned this Sep 21, 2016
@gerryqd
Copy link
Author

gerryqd commented Sep 29, 2016

Seems that it is fixed, right?

I built it on debian 8.6, though I have not install pandoc, it can be built out successfully.

I also verified this on Cygwin.

@texane
Copy link
Collaborator

texane commented Sep 29, 2016

Yes. The fix is not clean, but it now works without pandoc installed.

2016-09-29 15:10 GMT+02:00 gerryqd notifications@github.com:

Seems that it is fixed, right?

I built it on debian 8.6, though I have not install pandoc, it can be
built out successfully.

I also verified this on Cygwin.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#479 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEeH8EquMoiOteW3DsRuw-_CgBt4Xraks5qu7jFgaJpZM4KCsU4
.

@xor-gate
Copy link
Member

@gerryqd could you try on latest master?

@xor-gate
Copy link
Member

Related to #487, fixed in commit 68b0f3b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants