Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings/error break build for gcc 7 #590

Closed
atu-guda opened this issue May 7, 2017 · 2 comments · Fixed by #591
Closed

Warnings/error break build for gcc 7 #590

atu-guda opened this issue May 7, 2017 · 2 comments · Fixed by #591

Comments

@atu-guda
Copy link
Contributor

atu-guda commented May 7, 2017

  • [x ] Programmer/board type: Stlink/v2, Stlink/v2-onboard, Stlink/V2-1 onboard
  • [X ] Operating system: Linux Fedora 26+
  • [X ] Stlink tools version v1.3.1/git-cc3a5705099019e01dc59f7907d0c5b1b85878d8

During compilation with gcc 7.0.1, some warnings about fall through (missing break)
is reported. This warnings is treated as errors, so make fails to build.

Output:

stlink-20170507/src/gdbserver/gdb-server.c:1626:31: error: this statement may fall through [-Werror=implicit-fallthrough=]
                     case '4': { // insert access watchpoint

stlink-20170507/src/gdbserver/gdb-server.c:1663:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
                         if(delete_data_watchpoint(sl, addr) < 0) {

A patch is ready. Will try to submit it.

@atu-guda
Copy link
Contributor Author

atu-guda commented May 7, 2017

stlink-addbreak.patch.txt

Sorry for '.txt' suffix, github do not support '.patch' files from here.

@xor-gate
Copy link
Member

xor-gate commented May 8, 2017

Please submit a git pull request, we don't accept verbatim patches.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants