Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang 4.0.0+ can not compile version 1.4.0 #628

Closed
blacklion opened this issue Aug 21, 2017 · 6 comments · Fixed by #648
Closed

clang 4.0.0+ can not compile version 1.4.0 #628

blacklion opened this issue Aug 21, 2017 · 6 comments · Fixed by #648

Comments

@blacklion
Copy link

clang 4.0.0 or newer can not compile 1.4.0 release because it uses

add_cflag_if_supported("-Wall")
add_cflag_if_supported("-Wextra")
add_cflag_if_supported("-Werror")

in CFlags.cmake, and later add integer to string literal (in logging code), which is warning for clang. Build log is attached,

build.txt

@xor-gate
Copy link
Member

xor-gate commented Aug 21, 2017

This is the same error as build with ninja and GCC in PR #624. We need to fix this in the logging module.

@slyshykO
Copy link
Collaborator

slyshykO commented Oct 25, 2017

we can use strrchr for extracting the base name.
Another problem is the dir separator on windows depends on compiler and cmake generator. And can be both '\' and '/' .

@xor-gate
Copy link
Member

Yes for windows you can have multiple path separators (cygwin/mingw/native).

slyshykO added a commit to slyshykO/stlink that referenced this issue Oct 25, 2017
@slyshykO
Copy link
Collaborator

Is it still a bug?

@blacklion
Copy link
Author

I've checked very last "master" (95b6e03), and it build flawlessly with clang 5.0.0 on 64-bit system.
Thank you!

@xor-gate
Copy link
Member

xor-gate commented Oct 29, 2017

Thanks all for being proactive. Probably fixed this issue by PR #648

@xor-gate xor-gate modified the milestones: Unplanned (Contributions Welcome), v1.5.0 Oct 29, 2017
@Nightwalker-87 Nightwalker-87 linked a pull request Mar 18, 2020 that will close this issue
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants