Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License of (some) flashloaders source files missing #682

Closed
bluca opened this issue Mar 10, 2018 · 8 comments · Fixed by #683
Closed

License of (some) flashloaders source files missing #682

bluca opened this issue Mar 10, 2018 · 8 comments · Fixed by #683
Labels
general/documentation question status/resolved
Milestone
v1.5.1

Comments

@bluca
Copy link
Contributor

bluca commented Mar 10, 2018

Hi,

I would like to upload stlink to Debian. Before I can do that, I noticed that only 2 of the 8 files in flashloaders/ have a license - what about the others? Are they under the project-wide BSD-3-clause?
@bluca bluca changed the title License of flashloaders source files License of (some) flashloaders source files missing Mar 10, 2018
@xor-gate
Copy link
Member

Thats a very good question. There indeed a few bootloaders which are taken from the OpenOCD project under GPL. The others are based on the application note of the manifacturer, so they are part of the project which is indeed licensed as BSD-3-clause. If it is not clear you could propose a patch (PR) with correct headings. Thanks for the effort!

@bluca
Copy link
Contributor Author

bluca commented Mar 12, 2018

So only flashloaders/stm32l0x.s and flashloaders/stm32lx.s are marked as GPL-2+ (I'll send a PR later to clarify the bit in the README.md), from the git log or the files I cannot say if any other are not BSD licensed - do you know if those 2 are the only exceptions?

bluca added a commit to bluca/stlink that referenced this issue Mar 13, 2018
@bluca
Clarify license of flashloaders in README.md
4037bff 
Fixes stlink-org#682
xor-gate pushed a commit that referenced this issue Mar 16, 2018
@xor-gate
Debian packaging, CMake and README.md fixes (#683)
e9fe4e5 
* Use https for debian/copyright

* Update dates and fix stanzas in debian/copyright

No need to have 2 stanzas for the same license

* Add BSD-3-clause body in debian/copyright

* Remove generated boilerplate from debian/rules

* Enable compiler hardening flags in debian/rules

* Fix source package name according to repo and docs

* Set source package section to electronics

See https://packages.debian.org/unstable/electronics/ for a full list

* Add long descriptions to packages

* Add gbp.conf file

* Update changelog for 1.5.0 release

* Remove dirs files, not needed anymore

* Rename library package to match SONAME

As per Debian policy, shared library packages must be named after
their SONAME version.

* libstlink0: break+replace libstlink since it took over its files

* Remove triggers, not needed anymore

debhelper tools will generate the triggers file automatically since
the package name was corrected

* List GPL2+ in debian/copyright for flashloaders

* Do not append -shared to shared library on *NIX

Only on Windows it's necessary to have different file names, on *NIX
the extension is what disambiguates between a static library (.a) and
a shared library (.so).

* Clarify license of flashloaders in README.md

Fixes #682

* List all individual authors in debian/copyright

The Debian FTP masters nowadays require that all authors are listed in
debian/copyright. Print the list of authors from git.

* Move modprobe and udev files from shared library package to tools package

Multiple versions of a shared library might be installed on the same
system. Do not ship unversioned files in their packages, or they will
conflict and fail to install.

* stlink-tools: break+replace libstlink

It took ownership of udev and modprobe files from libstlink

* Fix pkgconfig include dir: remove project version

The headers are installed in /usr/include/stlink without a version
number.

* Add libstlink1 symbols file

Generated with:

 dpkg-gensymbols -P/tmp -v1.5.0 -V -e/tmp/libstlink.so.1.5.0
  -plibstlink1 -Odebian/libstlink1.symbols

* Bump Standards-Version to 4.1.3

Main changes are shared library rename and files moved, and HTTPS
URLs.

https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt

* Add debian/watch file for notifications

The Debian package tracker can automatically notify when a new
version is out.
@Nightwalker-87 Nightwalker-87 added this to the v1.5.1 milestone Mar 18, 2020
@xor-gate xor-gate reopened this Apr 9, 2020
@xor-gate
Copy link
Member

xor-gate commented Apr 9, 2020

@Nightwalker-87 we need to update LICENSE and add the GPL part also for those files. I had some discussion in an email with the original authors which seemed to be copied from the OpenOCD project into stlink project. So we have a mix of GPL van BSD licensed code. If something is unclear please post a comment.

@xor-gate
Copy link
Member

xor-gate commented Apr 9, 2020

Also @Nightwalker-87 it seems this issue is floating in the v1.5.1 milestone where 3 tickets are still open, I move them to the new milestone and next milestone so we sort out those things :=)

@xor-gate xor-gate modified the milestones: v1.5.1, v1.6.1 Apr 9, 2020
@xor-gate
Copy link
Member

xor-gate commented Apr 9, 2020

I moved the issue to milestone v1.6.1 which is easy to fix. Also closed dangling v1.5.1 which was already release by me long time ago.

@Nightwalker-87
Copy link
Member

Yes, ok, i'll look at it. Thx.

@Nightwalker-87
Copy link
Member

I moved the issue to milestone v1.6.1 which is easy to fix. Also closed dangling v1.5.1 which was already release by me long time ago.

No, please don't close any milestones which are open, this is on purpose as I am still reviewing old leftovers. Otherwise I can't keep on track with this.

@Nightwalker-87
Copy link
Member

We'll open a new ticket for this instead of recycling this old issue.

@Nightwalker-87 Nightwalker-87 modified the milestones: v1.6.1, v1.5.1 Apr 9, 2020
@Nightwalker-87 Nightwalker-87 mentioned this issue Apr 9, 2020
Closed
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
general/documentation question status/resolved
Projects
None yet
Milestone
v1.5.1
Development

Successfully merging a pull request may close this issue.

Debian packaging, CMake and README.md fixes bluca/stlink
3 participants
@bluca @xor-gate @Nightwalker-87