Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add png icon #684

Closed
Vascom opened this issue Mar 16, 2018 · 4 comments · Fixed by #708
Closed

Please add png icon #684

Vascom opened this issue Mar 16, 2018 · 4 comments · Fixed by #708
Labels
code/feature-request component/stlink-gui os/linux status/resolved
Milestone
v1.5.1

Comments

@Vascom
Copy link
Collaborator

Vascom commented Mar 16, 2018

Can you add icon in PNG format for use in desktop file? Now stlink menu entry has blank icon and it is not good.
It should be 512x512 picture.
@xor-gate xor-gate added this to the Unplanned (Contributions Welcome) milestone Mar 16, 2018
@xor-gate
Copy link
Member

Feel free to submit a PR, I only run OS X desktop.

@Vascom
Copy link
Collaborator Author

Vascom commented Mar 19, 2018

And it has no any icon on OS X?

@xor-gate
Copy link
Member

xor-gate commented Mar 26, 2018 •
edited
Loading

Its just an CLI application, no GUI (on systems without GTK)

@joede joede mentioned this issue Apr 17, 2018
Merged
@joede
Copy link
Contributor

joede commented Apr 17, 2018

I've added PR #708 to make the first step. I don't know CMake, so there is work needed.

@Nightwalker-87 Nightwalker-87 modified the milestones: Unplanned (Contributions Welcome), Next, General, v1.6.1 Feb 19, 2020
@Nightwalker-87 Nightwalker-87 modified the milestones: v1.6.1, v1.5.1 Mar 18, 2020
@Nightwalker-87 Nightwalker-87 linked a pull request Mar 18, 2020 that will close this issue
Add creation of icons for .desktop file #708
Merged
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code/feature-request component/stlink-gui os/linux status/resolved
Projects
None yet
Milestone
v1.5.1
Development

Successfully merging a pull request may close this issue.

Add creation of icons for .desktop file joede/stlink
4 participants
@Vascom @xor-gate @joede @Nightwalker-87