Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st-flash: incorrect file name handling #879

Closed
tdjastrzebski opened this issue Mar 16, 2020 · 5 comments · Fixed by #921
Closed

st-flash: incorrect file name handling #879

tdjastrzebski opened this issue Mar 16, 2020 · 5 comments · Fixed by #921
Assignees
@chenguokai
Labels
code/feedback component/st-flash status/duplicate status/no-bug status/resolved
Milestone
v1.6.1

Comments

@tdjastrzebski
Copy link

In case of incorrect bin file name st-flash fails with error:
ERROR common.c: map_file() == -1
I suggest more descriptive message.
@Nightwalker-87
Copy link
Member

So what would you suggest instead?

@Nightwalker-87 Nightwalker-87 added this to the Feedback required milestone Mar 17, 2020
@tdjastrzebski
Copy link
Author

I suggest message:
Unable to open [file-name] file.

@Nightwalker-87 Nightwalker-87 modified the milestones: Feedback required, v1.6.1 Mar 18, 2020
@Nightwalker-87
Copy link
Member

Ok, are you with Release v1.6.0 ?

@tdjastrzebski
Copy link
Author

tdjastrzebski commented Mar 18, 2020 •
edited
Loading

Yes, so far so good :)
It seems to work better than 1.5.1 although I have not tested it extensively yet.

@Nightwalker-87 Nightwalker-87 modified the milestones: v1.6.1, Feedback required Mar 20, 2020
@Nightwalker-87
Copy link
Member

Duplicate of #650.

@Nightwalker-87 Nightwalker-87 modified the milestones: Feedback required, v1.6.1 Mar 30, 2020
@Nightwalker-87 Nightwalker-87 mentioned this issue Apr 12, 2020
Closed
5 tasks
@Nightwalker-87 Nightwalker-87 linked a pull request Apr 12, 2020 that will close this issue
Enhance error log with file path for map_file() #921
Merged
@chenguokai chenguokai mentioned this issue Apr 12, 2020
Merged
@stlink-org stlink-org locked as resolved and limited conversation to collaborators May 6, 2020
@Nightwalker-87 Nightwalker-87 moved this to Done in Release v1.6.1 Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenguokai chenguokai

Labels
code/feedback component/st-flash status/duplicate status/no-bug status/resolved
Projects
No open projects
Release v1.6.1
Status: Done
Milestone
v1.6.1
Development

Successfully merging a pull request may close this issue.

Enhance error log with file path for map_file() chenguokai/stlink
3 participants
@tdjastrzebski @chenguokai @Nightwalker-87