Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform.txt): add default vid/pid definition #2454

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix(platform.txt): add default vid/pid definition #2454

merged 2 commits into from
Jul 19, 2024

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jul 18, 2024 •
edited

this avoids to add them to boards.txt if not needed.

cmake updated to get the default value from platform.txt.

/cc @massonal

This fixes this:
#2445 (comment)

@fpistm fpistm added the fix 🩹 Bug fix label Jul 18, 2024
@fpistm fpistm added this to the 2.8.1 milestone Jul 18, 2024
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jul 18, 2024
@fpistm fpistm mentioned this pull request Jul 18, 2024
Closed
@fpistm
fix(platform.txt): add default vid/pid definition
35252af 
this avoids to add them to boards.txt if not needed.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
chore(cmake): handle default vid/pid
115d040 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm merged commit a42bcfe into stm32duino:main Jul 19, 2024
23 checks passed
STM32 core based on ST HAL automation moved this from In progress to Done Jul 19, 2024
@fpistm fpistm deleted the default_vid_pid branch July 19, 2024 07:16
massonal
massonal reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@massonal massonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment at the top of platformtxt_filter is now outdated. It needs to mention this new policy wrt vid/pid.

@fpistm
Copy link
Member Author

fpistm commented Aug 12, 2024

The comment at the top of platformtxt_filter is now outdated. It needs to mention this new policy wrt vid/pid.

ecdf6af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massonal massonal massonal left review comments

Assignees
No one assigned
Labels
fix 🩹 Bug fix
Projects
STM32 core based on ST HAL
Status: Done
STM32 core based on ST HAL
  
Done
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpistm @massonal