Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Compile as C++17 for InnoDB #374

Closed
RingsC opened this issue Aug 8, 2022 · 1 comment · Fixed by #376
Closed

feature: Compile as C++17 for InnoDB #374

RingsC opened this issue Aug 8, 2022 · 1 comment · Fixed by #376
Assignees
Labels
A-feature feature with good idea C-stonedb-5.7 associated with stonedb 5.7 prio: high High priority

Comments

@RingsC
Copy link
Contributor

RingsC commented Aug 8, 2022

Is your feature request related to a problem? Please describe.

To support innodb is compiled as C++ 17. For now, tianmu is compiling as C++17, and C++17 has became mainstream of C++ standard. Therefore, now, we star to support to compile Innodb as C++17 in stonedb.
Describe the solution you'd like

Compiling with -std=c++1z.

This is backport from MySQL, which commit id is: 1a8a111d8f855a31d0aeffc8f02309b2b82dd410 and bug# is #32907274
Describe alternatives you've considered

Additional context

@RingsC RingsC added A-feature feature with good idea C-stonedb-5.7 associated with stonedb 5.7 labels Aug 8, 2022
@RingsC RingsC self-assigned this Aug 8, 2022
@RingsC RingsC added the prio: high High priority label Aug 8, 2022
@andyli029
Copy link
Contributor

andyli029 commented Aug 8, 2022

@mergify mergify bot closed this as completed in #376 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-feature feature with good idea C-stonedb-5.7 associated with stonedb 5.7 prio: high High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants