Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Q16- The data obtained in DEBUG mode is null #553

Closed
1 task done
adofsauron opened this issue Sep 22, 2022 · 1 comment
Closed
1 task done

bug: Q16- The data obtained in DEBUG mode is null #553

adofsauron opened this issue Sep 22, 2022 · 1 comment
Assignees
Labels
A-bug Something isn't working prio: high High priority

Comments

@adofsauron
Copy link
Collaborator

adofsauron commented Sep 22, 2022

Describe the problem

Mysql column storage engine -q16 -debug mode The data obtained is empty and to be fixed

int64_t VirtualColumnBase::GetMaxInt64(const core::MIIterator &mit) {
  int64_t res = GetMaxInt64Impl(mit);
  DEBUG_ASSERT(res != common::NULL_VALUE_64);
  if (Type().IsFloat()) {
    if (*(double *)&res > *(double *)&vc_max_val && vc_max_val != common::PLUS_INF_64 &&
        vc_max_val != common::NULL_VALUE_64)
      return vc_max_val;
  } else if ((vc_max_val != common::NULL_VALUE_64 && res > vc_max_val))
    return vc_max_val;
  return res;
}
 
int64_t VirtualColumnBase::GetMinInt64(const core::MIIterator &mit) {
  int64_t res = GetMinInt64Impl(mit);
  DEBUG_ASSERT(res != common::NULL_VALUE_64);
  if (Type().IsFloat()) {
    if (*(double *)&res < *(double *)&vc_min_val && vc_min_val != common::MINUS_INF_64 &&
        vc_min_val != common::NULL_VALUE_64)
      return vc_min_val;
  } else if ((vc_min_val != common::NULL_VALUE_64 && res < vc_min_val))
    return vc_min_val;
  return res;
}

Get data on a blank line:

image

SQL

select
	p_brand,
	p_type,
	p_size,
	count(distinct ps_suppkey) as supplier_cnt
from
	partsupp,
	part
where
	p_partkey = ps_partkey
	and p_brand <> 'Brand#45'
	and p_type not like 'MEDIUM POLISHED%'
	and p_size in (49,
	14,
	23,
	45,
	19,
	3,
	36,
	9)
	and ps_suppkey not in (
	select
		s_suppkey
	from
		supplier
	where
		s_comment like '%Customer%Complaints%' )
group by
	p_brand,
	p_type,
	p_size
order by
	supplier_cnt desc,
	p_brand,
	p_type,
	p_size;

Expected behavior

No response

How To Reproduce

No response

Environment

No response

Are you interested in submitting a PR to solve the problem?

  • Yes, I will!
@adofsauron adofsauron added the A-bug Something isn't working label Sep 22, 2022
@adofsauron adofsauron self-assigned this Sep 22, 2022
@adofsauron adofsauron added this to the stonedb_5.7_v1.0.2 milestone Sep 22, 2022
@RingsC RingsC added the prio: high High priority label Oct 14, 2022
@adofsauron
Copy link
Collaborator Author

adofsauron commented Nov 16, 2022

Stonedb no longer appears after version 1.0.1, but restarts when it reappears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bug Something isn't working prio: high High priority
Projects
None yet
Development

No branches or pull requests

2 participants