Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use wasm piece hasher #195

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat: use wasm piece hasher #195

merged 1 commit into from
Jun 20, 2024

Conversation

alanshaw
Copy link
Member

We removed this from the client library (and use the JS native version) since there's a miriad of environments that JS runs in that have differing ways to load WASM. However in Node.js it's a captive environment so should load fine and give us a little speedup.

@alanshaw alanshaw requested review from travis and hannahhoward June 19, 2024 16:48
Copy link
Member

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this seems right

@alanshaw alanshaw merged commit 8ddc4d2 into main Jun 20, 2024
1 check passed
@alanshaw alanshaw deleted the feat/use-wasm-piece-hasher branch June 20, 2024 13:20
alanshaw pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.8.0](v7.7.1...v7.8.0)
(2024-06-20)


### Features

* use wasm piece hasher
([#195](#195))
([8ddc4d2](8ddc4d2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants