Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Deployed Github pages URL has an extra column #64

Closed
tquiroga opened this issue May 31, 2019 · 4 comments · Fixed by #68
Closed

Deployed Github pages URL has an extra column #64

tquiroga opened this issue May 31, 2019 · 4 comments · Fixed by #68
Labels
released This issue/pull request has been released.

Comments

@tquiroga
Copy link

tquiroga commented May 31, 2019 •
edited
Loading

Minor issue spotted on the output of the command when deploying to github pages:

=> Storybook deployed to: https://:myusername.github.io/my-repo/
✨  Done in 53.60s.

There is an extra column https:// : myusername[...].
That crashes the convenient Ctrl+click in terminal window to open a URL in browser.
luksm added a commit to luksm/storybook-deployer that referenced this issue Sep 18, 2019
@luksm
fix: Updating git-url-parser
7e23884 
This new version doesn't have colon on the user or organization name, fixes storybook-eol#64
@luksm luksm mentioned this issue Sep 18, 2019
Merged
@jvanaert
Copy link

any news on merging this ?

@tehpsalmist
Copy link

Is this issue being tracked? tested? Seems like an easy fix, and it's hard to believe that I'm the only dev out there using ssh for my git config...

@hipstersmoothie
Copy link
Contributor

🚀 Issue was released in v2.8.4 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Apr 2, 2020
@hipstersmoothie
Copy link
Contributor

🚀 Issue was released in v2.8.4 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Updating git-url-parser luksm/storybook-deployer
4 participants
@jvanaert @hipstersmoothie @tquiroga @tehpsalmist