Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Personal access token not applied for enterprise github #74

Closed
Boughtmanatee5 opened this issue Nov 15, 2019 · 0 comments
Closed

Personal access token not applied for enterprise github #74

Boughtmanatee5 opened this issue Nov 15, 2019 · 0 comments

Comments

@Boughtmanatee5
Copy link

Description:
Personal access tokens aren't prepended to the github url unless the host url is "github.com".
https://github.com/storybookjs/storybook-deployer/blob/6aacf53ec6db2e978796a02a01f7517e9d299e89/bin/storybook_to_ghpages#L62

Proposed Solution:
Maybe the condition could just be if (args.HOST_TOKEN)? I'm not sure if there's a security concern around making sure the HOST_TOKEN is only sent to github.com.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants