Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that this addon doesn't work with CRA or <6.2 storybook #14

Open
phated opened this issue Jan 26, 2021 · 5 comments
Open

Note that this addon doesn't work with CRA or <6.2 storybook #14

phated opened this issue Jan 26, 2021 · 5 comments
Assignees
@phated

Comments

@phated
Copy link
Contributor

phated commented Jan 26, 2021

No description provided.

@phated phated self-assigned this Jan 26, 2021
@ranisalt
Copy link

ranisalt commented Feb 9, 2021

Why?

@phated
Copy link
Contributor Author

phated commented Feb 9, 2021

Before Storybook 6.2, it used to install additional loaders on .css and that causes this to crash. In the same way, CRA already had postcss and other loaders on the .css extension that crash this.

@sielay

This comment has been minimized.

Sign in to view
@phated
Copy link
Contributor Author

phated commented Feb 20, 2021

@sielay We won't be changing the plugin based on your suggestion because it changes the way CRA works between your storybook and starting your application. CRA doesn't load postcss config files.

@davidzzheng davidzzheng mentioned this issue Mar 24, 2021
Closed
@johnpangalos
Copy link

Is there anyway we could add these requirements to the Readme? Might save people some time.

@blowsie blowsie mentioned this issue Apr 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phated phated

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sielay @phated @ranisalt @johnpangalos