Merge pull request #224 from storybookjs/fix-legacy-story-parameters

fix: `parameters` attribute from legacy `<Story>` being removed
storybookjs · Oct 29, 2024 · e9c7cd2 · e9c7cd2
2 parents aaa2def + 6c887e6
commit e9c7cd2
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 0 deletions.
diff --git a/src/compiler/pre-transform/codemods/legacy-story.test.ts b/src/compiler/pre-transform/codemods/legacy-story.test.ts
@@ -279,4 +279,59 @@ describe(transformLegacyStory.name, () => {
       </Story>"
     `);
   });
+
+  it("leaves existing Story parameters untouched", async ({
+    expect,
+  }) => {
+    const code = `
+      <script context="module">
+        import { Story } from "@storybook/addon-svelte-csf";
+      </script>
+
+      <Story
+        name="Default"
+        parameters={{ 
+          sveltekit_experimental: {
+            stores: {
+              page: {
+                data: {
+                  test: 'passed',
+                },
+              },
+              navigating: {
+                route: {
+                  id: '/storybook',
+                },
+              },
+              updated: true,
+            },
+          },
+        }}
+      >
+        <h1>{"Test"}</h1>
+      </Story>
+    `;
+    const component = await parseAndExtractSvelteNode<SvelteAST.Component>(code, 'Component');
+
+    expect(
+      print(
+        transformLegacyStory({
+          component,
+          state: { componentIdentifierName: {} },
+        })
+      )
+    ).toMatchInlineSnapshot(`
+      "<Story name="Default" parameters={{
+      	sveltekit_experimental: {
+      		stores: {
+      			page: { data: { test: 'passed' } },
+      			navigating: { route: { id: '/storybook' } },
+      			updated: true
+      		}
+      	}
+      }}>
+      	<h1>{"Test"}</h1>
+      </Story>"
+    `);
+  });
 });
diff --git a/src/compiler/pre-transform/codemods/legacy-story.ts b/src/compiler/pre-transform/codemods/legacy-story.ts
@@ -109,6 +109,10 @@ export function transformLegacyStory(params: Params): SvelteAST.Component {
     });
   }
 
+  if (parameters) {
+    newAttributes.push(parameters);
+  }
+
   if (tags) {
     newAttributes.push(tags);
   }