-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support of Svelte 4 #109
Comments
I'd be happy to take a look at any PRs adding support for Svelte 4. At the minimum we'd need to bump the versions of |
it looks like there is a bit more to do: I tried to simply update it, but it looks like the The only reference to that module in this project that I can find is in the storybook main.js. Shouldn't it be possible to completely remove this module and use the "standard" vite way of bundling instead of webpack? |
Thanks for trying @RSWilli !
|
That's what I suspected, I am going to try again, since addon-svelte-csf is the only dependency that blocks the update to svelte 4 in my repositories. |
I give up again. I tried, but with the vite loader I am getting errors that I cannot explain. Aka: some of the webpack stuff seems to do something After your PR it should be easier to update this repo though. |
@RSWilli Storybook has been updated to support svelte 4 now (https://github.com/storybookjs/storybook/releases/tag/v7.0.27) if you wanted to give it another shot. I'm also seeing an issue with HMR where if you change a story the HMR refresh will overwrite all template args with the args from the last story. But I didn't want to raise that issue until this addon properly supports svelte 4 |
@rory-orennia I'm at it, although I will not do anything about the HMR issue you mentioned |
My hope was that it's caused by the outdated dependencies. I'll raise the issue after this is merged if it still exists |
🚀 Issue was released in |
Describe the feature
Is there a plan to support Svelte 4? I would be happy to help with this if possible.
Storybook has an alpha release in the oven where it will support Svelte v4: storybookjs/storybook#23197
Additional context
https://svelte.dev/blog/svelte-4
The text was updated successfully, but these errors were encountered: