Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [next] Legacy Story parameters is being removed in pre-transform #223

Closed
xeho91 opened this issue Oct 29, 2024 · 2 comments · Fixed by #224
Closed

[Bug] [next] Legacy Story parameters is being removed in pre-transform #223

xeho91 opened this issue Oct 29, 2024 · 2 comments · Fixed by #224
Assignees
Labels
bug Something isn't working prerelease This change is available in a prerelease.

Comments

@xeho91
Copy link
Collaborator

xeho91 commented Oct 29, 2024

Found by @paoloricciuti via Discord

Input:

<script context="module">
  import { Story } from "@storybook/addon-svelte-csf";
</script>

<Story
  name="Default"
  parameters={{ 
    sveltekit_experimental: {
      stores: {
        page: {
          data: {
            test: 'passed',
          },
        },
        navigating: {
          route: {
            id: '/storybook',
          },
        },
        updated: true,
      },
    },
  }}
>
  <h1>{"Test"}</h1>
</Story>

Output:

<Story name="Default">
  <h1>{"Test"}</h1>
</Story>
@xeho91 xeho91 added the bug Something isn't working label Oct 29, 2024
@xeho91 xeho91 self-assigned this Oct 29, 2024
xeho91 added a commit that referenced this issue Oct 29, 2024
@xeho91 xeho91 changed the title [Bug] [next] Legacy Story parameters get removed in pre-transform [Bug] [next] Legacy Story parameters is being removed in pre-transform Oct 29, 2024
@shilman
Copy link
Member

shilman commented Oct 29, 2024

🚀 Issue was released in v5.0.0-next.9 🚀

@shilman shilman added the prerelease This change is available in a prerelease. label Oct 29, 2024
@shilman
Copy link
Member

shilman commented Oct 29, 2024

🚀 Issue was released in v5.0.0-next.9 🚀

@xeho91 xeho91 linked a pull request Nov 1, 2024 that will close this issue
@xeho91 xeho91 closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants