Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish ESM #29

Closed
shilman opened this issue Jun 8, 2021 · 3 comments
Closed

Publish ESM #29

shilman opened this issue Jun 8, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@shilman
Copy link
Member

shilman commented Jun 8, 2021 •
edited
Loading

Describe the bug

Webpack dependency for this package is causing problems for Vite users here storybookjs/builder-vite#16 (comment)

Meanwhile @winkerVSbecks has added ESM support to addon-kit here: storybookjs/addon-kit#11

If we could get those changes into this package & republish, that might help the Vite users move forward cc @TheComputerM

@j3rem1e WDYT?
@shilman shilman added the enhancement New feature or request label Jun 8, 2021
@TheComputerM
Copy link
Contributor

Can I try to add ESM support? will you merge it?

@TheComputerM
Copy link
Contributor

@shilman #30

@shilman
Copy link
Member Author

shilman commented Jun 10, 2021

Merged & published as 1.1.0

@shilman shilman closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shilman @TheComputerM