MDX transformation fails

[sveisvei]

Running the code in the readme and then building the static version does not work out of the box.

Does output "unexpected" large output as well.

vs without the mdx file:

[eirslett]

Takk for sist! 😃

Is this with the latest version of Storybook (6.3-alpha-something) and the latest version of the builder? What about it is not working? MDX should at least work in development mode, I haven't checked the static build yet.

I agree that the file sizes look pretty huge. Maybe the addon-docs component itself is pretty heavy? We should compare the numbers to the Webpack version, I'm not sure if the large bundle size is Vite's fault or not.

[sveisvei]

Takk for sist ja, tiden flyr :)!

It was just an observation, I have not checked what the expected size is yet - will check this soon.

[lmestel]

Hi,

running the react example with a MDX story results in an empty Docs page and Uncaught TypeError: Cannot read property 'fromId' of undefined. Canvas looks good.

Here is a repo to reproduce: https://github.com/lmestel/storybook-builder-vite (with a Button.stories.mdx in the example-react package)

[eirslett]

I wonder if this could be related to Typescript-docgen-plugin or something like that? It's still missing in the Vite builder... (nobody has implemented it yet)

[shilman]

There is code in the preview that sets up a react context called DocsContext with a storyStore, and somehow that isn't getting set properly in the vite-builder:

https://github.com/storybookjs/storybook/blob/next/lib/core-client/src/preview/StoryRenderer.tsx#L320

Unrelated to react-docgen-typescript-plugin AFAIK. Also we are thinking about getting rid of that and taking a different approach that is builder-agnostic -- not sure about the timeline on that though. cc @bebraw

[eirslett]

This should be fixed in the latest release (with Storybook 6.3.4 or newer)