Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React 18 to peer dependency range #153

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add React 18 to peer dependency range #153

merged 1 commit into from
Jun 28, 2022

Conversation

Methuselah96
Copy link
Contributor

Resolves #152.

@xyc xyc requested review from bcomnes and ndelangen June 14, 2022 02:30
@xyc
Copy link
Collaborator

xyc commented Jun 20, 2022

@ndelangen any chance you know why chromatic tests are failing? The build seems to be passing. https://www.chromatic.com/build?appId=5d8cb665bc622e0020296079&number=143

@cameron-martin
Copy link

cameron-martin commented Jun 23, 2022 •
edited
Loading

Do you need to re-run it after accepting the snapshots or something?

@xyc
Copy link
Collaborator

xyc commented Jun 25, 2022

Rerun works!

@ndelangen ndelangen merged commit 3986c5c into storybookjs:master Jun 28, 2022
@Methuselah96 Methuselah96 deleted the react-18 branch June 29, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@xyc xyc xyc approved these changes

@bcomnes bcomnes Awaiting requested review from bcomnes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could we have the peer deps updated for React 18?
4 participants
@Methuselah96 @xyc @cameron-martin @ndelangen