Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore storybook-addon-links #1016

Closed
3 tasks done
shilman opened this issue May 10, 2017 · 2 comments
Closed
3 tasks done

Restore storybook-addon-links #1016

shilman opened this issue May 10, 2017 · 2 comments
Assignees
Labels

Comments

@shilman
Copy link
Member

shilman commented May 10, 2017

What happened

  1. We consolidated all packages into the monorepo
  2. We marked all of the original package repos as deprecated
  3. https://github.com/storybooks/storybook-addon-links did not get transitioned to the monorepo
  4. I read a stale PR and assessed that addon-links was deprecated
  5. I started to remove addon-links from the docs and from the code, e.g. Remove all references to addons-links #1015

However, now as far as I can tell, the only problem was that addon-links was not properly ported to the monorepo.

What needs to happen

  • addon-links ported to monorepo and tested
  • documentation updated to refer to addon-links as a standalone package
  • "built-in" actions and linkTo API should be deprecated (with 3.0?)
@thani-sh
Copy link
Contributor

Version 3.0 is a good time to remove actions and linkTo APIs from core. But let's add a warning log in when using these APIs and make sure it continues to work for now. It'll be no longer supported from v3.0 and we can remove it completely at a later version. What do you think?

@ndelangen
Copy link
Member

I should merge https://github.com/storybooks/storybook-addon-links into the monorepo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants