-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Extract ArgType parameters by component #10844
Comments
@tmeasday this requires:
Pretty sure I'd come up with a plan when we did the normalization work, but none of that is implemented AFAICT and it seems like a bigger task than I'd thought. WDYT? |
Sounds about right! I'm not sure how hard it is to update the individual enhancers @shilman but if we decide on the API the store part will be quick I think. |
@tmeasday I've highlighted all the extractors in this PR: https://github.com/storybookjs/storybook/pull/11068/files In the code, I only see one |
Won't fix. On-demand architecture fixes plus we're moving to annotations server in the future. |
#10373 intended to reduce the data sent over the channel on app startup by "normalizing" story parameters (e.g. sending component-level parameters once per component rather than once per story).
It appears that component ArgTypes are being sent per-story rather than per-component, thus losing out on a performance opportunity. Need to fix the
argTypes
extractor to do the right thing.The text was updated successfully, but these errors were encountered: