-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation mentions deprecated 'actions' and 'linkTo' addons as part of core #1113
Comments
@gabor which version of storybook are you using? we are in the process of deprecating the "use the addon with out installing it", so it should still work but will get phased out in 4.0. |
ESlint is correct, you should list it as a dependency. If you can link us to the docs we'll change it. We already have a PR upgrading the docs to Here: storybook-eol/storybooks.github.io#54 I'm pretty sure we fixed it there, If you can still find it, let me know and re-open this issue, thanks! |
thank you for the info... the docs-page is https://github.com/storybooks/storybook/blob/master/addons/actions/README.md, contains the @ndelangen about the mentioned pull-request, i see it's about the documentation-site... on that site, at https://storybooks.js.org/docs/react-storybook/addons/addon-gallery/ again mentions that |
We will need to update the docs!, thanks for checking. PR is very much welcome btw 🙏 |
Fixed! |
the documentation says that this addon can be used without installing it.
but if you use it like
import { action } from '@storybook/addon-actions'
theneslint
does not like it because it triggers the import/no-extraneous-dependencies warning (we are using a module that is not mentioned inpackage.json
).i can fix this by explicitly adding the package to
package.json
, but i wonder what is the recommended approach here.The text was updated successfully, but these errors were encountered: