Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation mentions deprecated 'actions' and 'linkTo' addons as part of core #1113

Closed
gabor opened this issue May 24, 2017 · 5 comments
Closed

Comments

@gabor
Copy link

gabor commented May 24, 2017

the documentation says that this addon can be used without installing it.
but if you use it like import { action } from '@storybook/addon-actions' then eslint does not like it because it triggers the import/no-extraneous-dependencies warning (we are using a module that is not mentioned in package.json).

i can fix this by explicitly adding the package to package.json, but i wonder what is the recommended approach here.

@shilman
Copy link
Member

shilman commented May 24, 2017

@gabor which version of storybook are you using? we are in the process of deprecating the "use the addon with out installing it", so it should still work but will get phased out in 4.0.

@ndelangen
Copy link
Member

ndelangen commented May 24, 2017

ESlint is correct, you should list it as a dependency. If you can link us to the docs we'll change it.

We already have a PR upgrading the docs to 3.0.0.

Here: storybook-eol/storybooks.github.io#54
Care to review it @gabor ? ♥️

I'm pretty sure we fixed it there, If you can still find it, let me know and re-open this issue, thanks!

@gabor
Copy link
Author

gabor commented May 24, 2017

thank you for the info... the docs-page is https://github.com/storybooks/storybook/blob/master/addons/actions/README.md, contains the You can use this addon without installing it manually. text.

@ndelangen about the mentioned pull-request, i see it's about the documentation-site... on that site, at https://storybooks.js.org/docs/react-storybook/addons/addon-gallery/ again mentions that These addons ship with Storybook by default. You can use them right away.. i did not see this file getting changed in the mentioned pull-request.

@ndelangen ndelangen reopened this May 24, 2017
@ndelangen
Copy link
Member

We will need to update the docs!, thanks for checking. PR is very much welcome btw 🙏

@ndelangen ndelangen changed the title addon-actions linter issue documentation mentions deprecated 'actions' and 'linkTo' addons as part of core May 24, 2017
@ndelangen ndelangen self-assigned this May 24, 2017
@ndelangen
Copy link
Member

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants