-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with deepEqual in SourceContainer #11413
Labels
Milestone
Comments
Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.41 containing PR #11414 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
Great news! I'll give it a go today. |
This was referenced Dec 15, 2021
This was referenced Jun 2, 2022
This was referenced Sep 25, 2023
This was referenced Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
My current Storybook setup works up to and including v6.0.0-beta.37. However, once Storybook dependencies are updated to v6.0.0-beta.38, the stories break on the deepEqual check in SourceContainer. The changes were introduced in #11332.
storybook/addons/docs/src/blocks/SourceContainer.tsx
Line 35 in b25b434
I suspect that it results in a false positive by checking equality of initial sources ({}) with sourcesRef.current that is undefined in my case. An additional check for undefined ref value seems reasonable:
I appreciate the work you guys are doing and hope this is a relatively easy fix!
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Code snippets
If applicable, add code samples to help explain your problem.
System:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: