Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing https import #1163

Closed
doctyper opened this issue May 30, 2017 · 5 comments
Closed

Missing https import #1163

doctyper opened this issue May 30, 2017 · 5 comments
Labels
Milestone

Comments

@doctyper
Copy link
Contributor

Hi.

It appears this import was removed from PR #735 which enabled HTTPS use. I'm not able to run start-storybook with HTTPS enabled:

@storybook/react v3.0.0

../node_modules/@storybook/react/dist/server/index.js:107
  server = https.createServer(sslOptions, app);
           ^

ReferenceError: https is not defined
    at Object.<anonymous> (.../node_modules/@storybook/react/dist/server/index.js:107:12)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3
@tmeasday tmeasday added the bug label May 30, 2017
@tmeasday
Copy link
Member

How did this pass linting I wonder?

@shilman
Copy link
Member

shilman commented May 30, 2017

@tmeasday see #1000

We need to get this merged 😕

@doctyper
Copy link
Contributor Author

@tmeasday
Copy link
Member

@shilman -- that PR is a bit noisy, what's the executive summary? @theinterned added some linting rules and they don't pass yet?

Let's just get some basic "this code won't run properly" rules going shall we? (make everything else a warning until we get around to fixing it)

@shilman
Copy link
Member

shilman commented May 30, 2017

@tmeasday yeah the original ESlint rules were way too lose. The PR title is "stricter", but I think that actually just means "basic rules". And AFAICT it was ready to merge at one point, so we should just fix it and get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants