-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing https import #1163
Comments
How did this pass linting I wonder? |
See also a similar bug found here: https://github.com/storybooks/storybook/blob/master/app/react/src/server/index.js#L62-L64 |
@shilman -- that PR is a bit noisy, what's the executive summary? @theinterned added some linting rules and they don't pass yet? Let's just get some basic "this code won't run properly" rules going shall we? (make everything else a warning until we get around to fixing it) |
@tmeasday yeah the original ESlint rules were way too lose. The PR title is "stricter", but I think that actually just means "basic rules". And AFAICT it was ready to merge at one point, so we should just fix it and get it in. |
Hi.
It appears this import was removed from PR #735 which enabled HTTPS use. I'm not able to run
start-storybook
with HTTPS enabled:The text was updated successfully, but these errors were encountered: