-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE11: centered layout param not centering vertically #12386
Comments
@petermikitsh would you be able to contribute a fix? |
This is a known bug in IE11 and there appears to be a workaround outlined in the highest rated comment here: philipwalton/flexbugs#231 Some ideas: Add a pseudo element after the flex element (in our case the body). body:after {
content: '';
min-height: inherit;
font-size: 0;
} Someone also suggested setting |
Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.0-rc.5 containing PR #13159 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
this change in #13159 actually added an unnecessary vertical scrollbar when using a /* Vertical centering fix for IE11 */
.sb-show-main.sb-main-centered:after {
content: '';
min-height: inherit;
font-size: 0;
} when changing do you want me to open a new issue for this? EDIT: to reproduce:
|
@stefanprobst The scrollbar bug was captured in #13178 (comment) and #13192 |
i guess this can be closed again after #13192 was merged? thanks! |
Describe the bug
Stories center horizontally, but not vertically, in IE 11.
To Reproduce
Expected behavior
Vertical centering occurs.
Screenshots
The official storybook is not loading in IE 11.
![Screen Shot 2020-09-04 at 10 15 55 AM](https://user-images.githubusercontent.com/1571918/92269446-0b95e000-ee99-11ea-9892-fdd5f805c7d0.png)
My personal storybook is, showing the vertical entering bug:
![Screen Shot 2020-09-04 at 10 34 00 AM](https://user-images.githubusercontent.com/1571918/92270059-392f5900-ee9a-11ea-99f4-f64b035265d4.png)
Expected behavior (centering in Chrome is correct):
![Screen Shot 2020-09-04 at 10 35 59 AM](https://user-images.githubusercontent.com/1571918/92270226-857a9900-ee9a-11ea-8511-79df3d6949d1.png)
Code snippets
System:
Please paste the results of
npx sb@next info
here.The text was updated successfully, but these errors were encountered: