Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorators: Protect id, name, kind and other "core" metadata #12737

Closed
shilman opened this issue Oct 12, 2020 · 9 comments
Closed

Decorators: Protect id, name, kind and other "core" metadata #12737

shilman opened this issue Oct 12, 2020 · 9 comments

Comments

@shilman
Copy link
Member

shilman commented Oct 12, 2020

Originally posted by @tmeasday in #12699 (comment)

Currently the decorator code disallows the user from overwriting story parameters in the story context. This should be updated to include other core metadata including:

  id,
  kind,
  name,
  story,
@shilman shilman added this to the 7.0 milestone Oct 12, 2020
@winnsterx
Copy link

I could take a look at this

@shilman
Copy link
Member Author

shilman commented Oct 12, 2020

that'd be awesome @winnayx

@adagar
Copy link
Contributor

adagar commented Jan 21, 2021

It doesn't seem like this was assigned nor progressed since October. Does it still need support? I could take a crack at it!

@tmeasday
Copy link
Member

Sure thing @adagar

@adagar
Copy link
Contributor

adagar commented Jan 27, 2021

hey @tmeasday thanks for the response, but I'm digging into a different ticket; this one is still up for grabs!

@apapadopoulou
Copy link
Member

Is this issue still open? A pull request is mentioned above so it is not clear to me whether someone is working on this.

@shilman
Copy link
Member Author

shilman commented Apr 5, 2021

Still open. If you're interested in helping please consider reviewing the PR mentioned above. We'll get it merged in SB 7.0 because it's technically a breaking change.

@apapadopoulou
Copy link
Member

Thank you, I will start off from there!

@shilman
Copy link
Member Author

shilman commented Apr 30, 2021

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.0-alpha.17 containing PR #13512 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants