Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-issue with hierarchical view in release/3.2 #1429

Closed
nutgaard opened this issue Jul 7, 2017 · 5 comments
Closed

UI-issue with hierarchical view in release/3.2 #1429

nutgaard opened this issue Jul 7, 2017 · 5 comments

Comments

@nutgaard
Copy link
Contributor

nutgaard commented Jul 7, 2017

Current behaviour

With long names it prefers to push the document-icon and storyname onto a new line before breaking the storyname. If there's not enough room on the next line it breaks the storyname as expected. image

Wanted/Expected behaviour

I would expect the opposite behaviour, e.g. start by breaking text and if its no longer possible pop it onto a new line (or just overflow).

Storybook-version: 3.2.0-alpha.7

@igor-dv
Copy link
Member

igor-dv commented Jul 7, 2017

I'll look into it. Thanks.

@igor-dv
Copy link
Member

igor-dv commented Jul 7, 2017

@nutgaard
BTW, do you think breaking the words is a good solution ?
Inspiring from the editor we all use and love (I think all of them do this):

image

WDYT ?

@igor-dv
Copy link
Member

igor-dv commented Jul 7, 2017

Here is the fix as you suggested.
storybook_hierarchy_react-treebeard-width

But IMO the better way is to support horizontal scrolling starting from some minimum width.

@nutgaard
Copy link
Contributor Author

nutgaard commented Jul 7, 2017

I think both approaches are viable.
But its probably easier to get the "overflow: hidden"-solution to work consistently, and paired with a horizontal scrollbar it solves the issue imho.

Anyway huge 👍 for the quick response. 🥇

@igor-dv
Copy link
Member

igor-dv commented Jul 7, 2017

Will be fixed with #1427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants