Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs/Source: setState called inside render function #16745

Closed
shilman opened this issue Nov 22, 2021 · 1 comment
Closed

Addon-docs/Source: setState called inside render function #16745

shilman opened this issue Nov 22, 2021 · 1 comment
Labels
addon: docs block: source bug

Comments

@shilman
Copy link
Member

shilman commented Nov 22, 2021

Originally posted by @shilman in #16709 (comment)

I'm getting this error when I click on react-ts AccountForm stories in docs mode, but I'm not seeing it in the built storybook for next (haven't investigated whether this is an issue with dev mode or with the branch)

Demo___Account_Form_-_Standard_⋅_Storybook_and_Demo___Account_Form_-_Standard_⋅_Storybook
@tmeasday tmeasday mentioned this issue Nov 26, 2021
Merged
@shilman
Copy link
Member Author

shilman commented Nov 26, 2021

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-rc.10 containing PR #16792 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: docs block: source bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shilman