Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dial back version conflict warnings #21849

Closed
shilman opened this issue Mar 31, 2023 · 1 comment · Fixed by #21850
Closed

[Bug]: Dial back version conflict warnings #21849

shilman opened this issue Mar 31, 2023 · 1 comment · Fixed by #21850
Assignees

Comments

@shilman
Copy link
Member

shilman commented Mar 31, 2023

Describe the bug

As part of a migration we now warn users about duplicate package versions #21791

However, this warning is overly aggressive and fires almost any time the user uses fixed versions of packages.

This is because:

  1. the fixed versions depend on fixed versions of SB packages inside the monorepo
  2. the fixed versions depend on version ranges of SB packages outside the monorepo
  3. the SB packages outside the monorepo depend on version ranges in the monorepo

Until we figure out a proper solution, we should dial back the warning to only warn if the minor versions are different (e.g. if you're running 7.1 + 7.0 together, 7.0 + 6.5, etc.)

To Reproduce

See mealdrop https://github.com/yannbf/mealdrop

System

No response

Additional context

No response

@shilman
Copy link
Member Author

shilman commented Mar 31, 2023

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.11 containing PR #21850 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants