Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @storybook/react-vite needs updated imports from react-docgen - exports were renamed in December 2022 #22406

Closed
nstuyvesant opened this issue May 5, 2023 · 3 comments

Comments

@nstuyvesant
Copy link

nstuyvesant commented May 5, 2023

Describe the bug

The module react-docgen@6.0.0-rc.8 renamed several exports several commits ago in December of 2022:
reactjs/react-docgen@0c2891d

This means that these lines of code will not work with the release candidate:
https://github.com/storybookjs/storybook/blob/next/code/frameworks/react-vite/src/plugins/react-docgen.ts#L5-L7

I will submit a PR.

@nstuyvesant nstuyvesant changed the title [Bug]: Storybook 7.0.8 - site won't load - blocking a release for us [Bug]: Storybook 7.0.8 - site won't load - blocking a release May 5, 2023
@Gitsack
Copy link

Gitsack commented May 5, 2023

Same issue with one of my repos - 7.0.7 worked fine. After upgrading to 7.0.8, there is just a white screen instead of storybook.

The following storybook packages are installed:

"@storybook/addon-a11y": "^7.0.7",
    "@storybook/addon-coverage": "^0.0.8",
    "@storybook/addon-essentials": "^7.0.7",
    "@storybook/addon-interactions": "^7.0.7",
    "@storybook/addon-links": "^7.0.7",
    "@storybook/addon-mdx-gfm": "^7.0.7",
    "@storybook/blocks": "^7.0.7",
    "@storybook/jest": "^0.1.0",
    "@storybook/nextjs": "^7.0.7",
    "@storybook/react": "^7.0.7",
    "@storybook/test-runner": "^0.10.0",
    "@storybook/testing-library": "^0.1.0",
    "@testing-library/jest-dom": "^5.16.5",
    "@testing-library/react": "^14.0.0",

Removing addon-mdx-gfm had no impact.

@nstuyvesant nstuyvesant changed the title [Bug]: Storybook 7.0.8 - site won't load - blocking a release [Bug]: Storybook 7.0.8 - storybook:react-docgen-plugin causes storybook site to not load May 6, 2023
@nstuyvesant nstuyvesant changed the title [Bug]: Storybook 7.0.8 - storybook:react-docgen-plugin causes storybook site to not load [Bug]: Storybook 7.0.9 - storybook:react-docgen-plugin causes storybook site to not load May 6, 2023
@nstuyvesant nstuyvesant changed the title [Bug]: Storybook 7.0.9 - storybook:react-docgen-plugin causes storybook site to not load [Bug]: Storybook 7.0.9 - @storybook/react-vite has invalid imports from react-docgen - exports were renamed in December 2022 May 6, 2023
@nstuyvesant nstuyvesant changed the title [Bug]: Storybook 7.0.9 - @storybook/react-vite has invalid imports from react-docgen - exports were renamed in December 2022 [Bug]: @storybook/react-vite needs updated imports from react-docgen - exports were renamed in December 2022 May 6, 2023
@shilman
Copy link
Member

shilman commented May 8, 2023

Is this actually a bug? Storybook depends on an older version of react-docgen and works fine with the version it depends on.

There are now a couple PRs to update to the latest RC: #22324 #22432

We should unify these PRs. As far as I know this is a maintenance issue and would be released as part of 7.1. But if I'm missing something and it's a bug, I'm happy to try to get it in faster and patch it back to 7.0.x

Thanks for any clarification you can provide!

@nstuyvesant
Copy link
Author

Did not intend to log as a bug - meant enhancement. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants