Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto migration: Detect .stories.mdx and @storybook/mdx1-csf usage #25433

Closed
Tracked by #25432
yannbf opened this issue Jan 3, 2024 · 2 comments · Fixed by #26102
Closed
Tracked by #25432

Auto migration: Detect .stories.mdx and @storybook/mdx1-csf usage #25433

yannbf opened this issue Jan 3, 2024 · 2 comments · Fixed by #26102
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented Jan 3, 2024

The work done in #25182 removed support for *.stories.mdx and the CSF in MDX format, which is impactful for a few users:

  • *.stories.mdx stories should be migrated to new *.mdx format (there is a codemod already here)
  • usage of the legacyMdx1 feature in main.js should be removed
export default {
  features: {
    legacyMdx1: true,
  },
};
@ndelangen
Copy link
Member

ndelangen commented Feb 20, 2024

@yannbf @valentinpalkovic @shilman any idea on how to actually implement this:

jsxOptions (addon option from addon-docs) should be removed (though I'm not sure if there's more to it)

Are we sure we want to spend the time, and add the complexity to our codebase for this?
AFAICS this option doesn't do anything anymore.
Screenshot 2024-02-20 at 09 00 23

@yannbf
Copy link
Member Author

yannbf commented Feb 21, 2024

@ndelangen I unfortunately do not have a lot of context on usage of the jsxOptions. All I know that it was part of mdx1 and that won't exist anymore because we removed it.

usrrname pushed a commit to usrrname/storybook that referenced this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants