Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SB8 UI, Search results on dark mode are tough to read #26018

Closed
domyen opened this issue Feb 13, 2024 · 6 comments · Fixed by #26287
Closed

[Bug]: SB8 UI, Search results on dark mode are tough to read #26018

domyen opened this issue Feb 13, 2024 · 6 comments · Fixed by #26287

Comments

@domyen
Copy link
Member

domyen commented Feb 13, 2024

Describe the bug

The search results for SB8 UI dark mode are currently a shade of gray that's tough to read. I'd expect the title to be closer to to white.
image

To Reproduce

  1. Spin up an SB8 project (like this one)
  2. Use the dark theme
  3. Search for something
  4. See the search result color

System

No response

Additional context

No response

@joevaugh4n
Copy link
Contributor

+1, would also expect white in dark mode

@sakit0
Copy link
Contributor

sakit0 commented Feb 20, 2024

Can I Have this issue?

@sash9696
Copy link

Hi @domyen @vanessayuenn . Could u please assign this to me.

@valentinpalkovic
Copy link
Contributor

Before someone starts on this, please let's wait on the feedback of some of our designers.

cc @cdedreuille, @MichaelArestad

@cdedreuille
Copy link
Contributor

Yes I believe the title should be white. Not sure what went wrong here when we recoded it.

@cdedreuille cdedreuille self-assigned this Feb 22, 2024
@vanessayuenn
Copy link
Contributor

@sakit0 @sash9696 we'd welcome a PR fixing this (changing the text to white as per @cdedreuille).

Be sure to check the contribution guide and hop onto the Storybook Discord if you need any help getting started. Looking forward to your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants